Run integration if SetDevVersion is true or not set in case of scheud… #11476
Conversation
praveenkuttappan
requested review from
weshaggard,
mikeharder and
chidozieononiwu
praveenkuttappan
requested review from
danieljurek,
KarishmaGhiya and
mitchdenny
as code owners
|
Where is SetDevVersion explicitly getting set to false? I'm mostly asking because this condition is the same across other languages like https://github.com/Azure/azure-sdk-for-net/blob/master/eng/pipelines/templates/stages/archetype-net-release.yml#L217 and I want to be sure we don't have a larger issue we should address. |
|
@weshaggard Dozie has set SetDevVersion to false in pipeline variables for js - template pipeline here. As per Dozie, this change was intentional and it seems it was done to avoid publishing template package regularly. I am not sure yet why we need to do that. But this PR is to avoid pipeline failure for template. |
|
OK I know @chidozieononiwu is working on some changes to our template package pipelines to help with testing our eng/common changes so I guess we will have to see where this all lands. However if we stick with this logic perhaps we should change the logic to be |
Azure#11476) * Run integration if SetDevVersion is true or not set in case of scheduled job
We decided to abandon that implementation. So I guess this no longer applies. |
SetDevVersion is set to false in pipeline variables and it properly skips setting build version as alpha. But this same variable is also used as job condition for Integration job(which uploads package to daily dev feed). Currently this condition is is evaluating to tru for scheduled job on internal project even if variable is explicitly set to false. Ideally Scheduled run should run this step if variable is set to true or empty.